Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidX migration #885

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

TalbotGooday
Copy link

@TalbotGooday TalbotGooday commented May 1, 2020

The support library artifacts are being deprecated and all future development is going into AndroidX, so there’s no point to avoiding this migration.

UPD: Full-migrated library is here https://github.com/TalbotGooday/AndroidPdfViewer. It also includes some forks from this repo

@katie0809
Copy link

katie0809 commented Jul 6, 2020

It seems like current AndroidPdfViewer library doesn't support an application migrated to androidX. Is it right?

@TalbotGooday
Copy link
Author

@katie0809 yeah, you are right. Here is a fork with AndroidX https://github.com/TalbotGooday/AndroidPdfViewer

implementation 'com.github.TalbotGooday:AndroidPdfViewer:3.1.0-beta.2'

@katie0809
Copy link

@TalbotGooday Thank you, actually I solved problems by adding maven { url 'https://maven.google.com' } to the build.gradle. And I don't know why...='(

@TalbotGooday
Copy link
Author

@katie0809 so your problem was not the "migration problem")

polesapart added a commit to polesapart/AndroidPdfViewer that referenced this pull request Jul 10, 2020
@madmas
Copy link

madmas commented Jul 14, 2020

👍 look good to me :) @barteksc any chance to get this merged and forge a release?

@madmas
Copy link

madmas commented Aug 4, 2020

@TalbotGooday as there seems to be no update in this place, have you consider to continue your fork?

@TalbotGooday
Copy link
Author

@madmas it all depends on what desires the community will have) Feel free to create issues in my fork)

@madmas
Copy link

madmas commented Aug 4, 2020

@TalbotGooday thanks for the quick response :)
actually, you don't have issues enabled:
grafik

@TalbotGooday
Copy link
Author

TalbotGooday commented Aug 4, 2020

@madmas oh, sorry. I will enable this option asap)

UPD: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants